Skip to content

OpenAI Admin Key Detector #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amanfcp wants to merge 12 commits into
base: main
Choose a base branch
from
Open

OpenAI Admin Key Detector #4689

amanfcp wants to merge 12 commits into from

Conversation

@amanfcp
Copy link
Contributor

@amanfcp amanfcp commented Jan 22, 2026

Description:

This PR adds OpenAI Admin Key Detector and enhances the pre-existing OpenAI detector to skip Admin Key verification

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@amanfcp amanfcp requested a review from a team January 22, 2026 16:27
@amanfcp amanfcp requested review from a team as code owners January 22, 2026 16:27
mustansir14
mustansir14 reviewed Jan 23, 2026
View reviewed changes
mustansir14
mustansir14 reviewed Jan 23, 2026
View reviewed changes
mustansir14
mustansir14 requested changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@mustansir14 mustansir14 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I have some concerns mentioned in the comments.

Also can we have tests demonstrating that admin keys are not being detected in the original detector and vice-versa?

@amanfcp amanfcp requested a review from mustansir14 January 26, 2026 11:36
MuneebUllahKhan222
MuneebUllahKhan222 reviewed Jan 27, 2026
View reviewed changes
mustansir14
mustansir14 reviewed Jan 28, 2026
View reviewed changes
mustansir14
mustansir14 approved these changes Jan 28, 2026
View reviewed changes
Copy link
Contributor

@mustansir14 mustansir14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

shahzadhaider1
shahzadhaider1 approved these changes Jan 28, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MuneebUllahKhan222 MuneebUllahKhan222 MuneebUllahKhan222 left review comments

@mustansir14 mustansir14 mustansir14 approved these changes

@shahzadhaider1 shahzadhaider1 shahzadhaider1 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amanfcp @mustansir14 @shahzadhaider1 @MuneebUllahKhan222